Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): v2.4.0-beta #2345

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

chore(release): v2.4.0-beta #2345

wants to merge 38 commits into from

Conversation

shamardy
Copy link
Collaborator

@shamardy shamardy commented Feb 8, 2025

changelog to be added...

onur-ozkan and others added 26 commits December 23, 2024 15:06
* add time validation core logic

Signed-off-by: onur-ozkan <[email protected]>

* nit fixes

Signed-off-by: onur-ozkan <[email protected]>

* handle time gap

Signed-off-by: onur-ozkan <[email protected]>

* improve logging

Signed-off-by: onur-ozkan <[email protected]>

* add more trackable processing logs

Signed-off-by: onur-ozkan <[email protected]>

* improve info log and remove debugging leftover

Signed-off-by: onur-ozkan <[email protected]>

* rename `NetworkInfoRequest` to `PeerInfoRequest`

Signed-off-by: onur-ozkan <[email protected]>

* handle recently dialed peers

Signed-off-by: onur-ozkan <[email protected]>

* add useful logs

Signed-off-by: onur-ozkan <[email protected]>

* create function for pre-dial check

Signed-off-by: onur-ozkan <[email protected]>

* set max cap for timestamp channel

Signed-off-by: onur-ozkan <[email protected]>

* remove leftover

Signed-off-by: onur-ozkan <[email protected]>

* use `Multiaddr` as key

Signed-off-by: onur-ozkan <[email protected]>

* fix p2p tests

Signed-off-by: onur-ozkan <[email protected]>

* update logs

Signed-off-by: onur-ozkan <[email protected]>

* rename leftovers

Signed-off-by: onur-ozkan <[email protected]>

* update timing values

Signed-off-by: onur-ozkan <[email protected]>

* minor fixes

Signed-off-by: onur-ozkan <[email protected]>

* update pre dial check calls

Signed-off-by: onur-ozkan <[email protected]>

* apply nit fixes

Signed-off-by: onur-ozkan <[email protected]>

* don't update existing expiries

Signed-off-by: onur-ozkan <[email protected]>

* revert breakage

Signed-off-by: onur-ozkan <[email protected]>

---------

Signed-off-by: onur-ozkan <[email protected]>
* handle p2p features properly

Signed-off-by: onur-ozkan <[email protected]>

* use `PeerId` type for timestamp channel straight away

Signed-off-by: onur-ozkan <[email protected]>

---------

Signed-off-by: onur-ozkan <[email protected]>
* update wasm build for docker

* lock wasm-pack version on build runners

Signed-off-by: onur-ozkan <[email protected]>

---------

Signed-off-by: onur-ozkan <[email protected]>
Co-authored-by: onur-ozkan <[email protected]>
…#2295)

* add feature flag to mm2_main and mm2_bin_lib tomls

* filter 'status:' pr labels

* remove old labels

* dont allow to pass blocked and invalid statuses

* pass in progress and pending review statuses

* update statuses list
* switch to proper rust caching

Signed-off-by: onur-ozkan <[email protected]>

* fix linting

Signed-off-by: onur-ozkan <[email protected]>

* rename cargo-cache to build-cache

Signed-off-by: onur-ozkan <[email protected]>

* try caching

Signed-off-by: onur-ozkan <[email protected]>

* switch to rust-cache

Signed-off-by: onur-ozkan <[email protected]>

---------

Signed-off-by: onur-ozkan <[email protected]>
* remove unnecessary Arc<

The inners are already `Arc<`ed

* eth websocket: avoid locking control message sender and clone it instead

* review(sami): move tx declaration close to where it's being used

* review(sami): free rx end out of the Arc

and arc the entire controller channel instead
* unlock wasm-pack version

Signed-off-by: onur-ozkan <[email protected]>

* force yes on docker build

Signed-off-by: onur-ozkan <[email protected]>

---------

Signed-off-by: onur-ozkan <[email protected]>
* fix peer response error log (only if error)

* add test for peer time difference validation

* fix linux clippy

* Revert "fix linux clippy"

This reverts commit 2bfe34c.

* Revert "add test for peer time difference validation"

This reverts commit c8d1165.

* Revert "fix peer response error log (only if error)"

This reverts commit b6d6fbc.

* add docker test for peer time sync validation

* remove unneeded test println

* use Mm2TestConf::seednode

* review(borngraced): refactor get_utc_timestamp with test code

* use const in peer time sync test
* Validate Cargo.lock

* Revert "Validate Cargo.lock" and add validate-cargo-lock.yml

* review: run only `cargo update` and simplify yml
* save dev state

Signed-off-by: onur-ozkan <[email protected]>

* save dev state

Signed-off-by: onur-ozkan <[email protected]>

* make proto types serializable for RPC endpoint

Signed-off-by: onur-ozkan <[email protected]>

* remove dummy test

Signed-off-by: onur-ozkan <[email protected]>

* add RPC error type

Signed-off-by: onur-ozkan <[email protected]>

* add TODO

Signed-off-by: onur-ozkan <[email protected]>

* fix status filtering

Signed-off-by: onur-ozkan <[email protected]>

* fix clippy warn

Signed-off-by: onur-ozkan <[email protected]>

* resolve `todo!()`s

Signed-off-by: onur-ozkan <[email protected]>

* remove inline attribute

Signed-off-by: onur-ozkan <[email protected]>

* improve `validators_rpc`

Signed-off-by: onur-ozkan <[email protected]>

* add coverage for tendermint_validators RPC

Signed-off-by: onur-ozkan <[email protected]>

* apply nit changes

Signed-off-by: onur-ozkan <[email protected]>

* document `ValidatorStatus`

Signed-off-by: onur-ozkan <[email protected]>

* use proper error variant on coin filtering

Signed-off-by: onur-ozkan <[email protected]>

* apply nits

Signed-off-by: onur-ozkan <[email protected]>

---------

Signed-off-by: onur-ozkan <[email protected]>
…ut (#2283)

This commit moves payment existence check in maker_payment/send_taker_payment before timeout validation and skips timeout if payment is already sent, as the taker swap should proceed to waiting for maker to spend the taker payment.
Fixes an issue where passphrases were incorrectly validated as BIP39 mnemonics during storage decryption. Now, passphrases no longer require bip39 validation.
This commit makes the build script straightforward and more stable without causing cache invalidation. The final versioning output remains as is, but the implementation side is robust than ever.
Bumps libp2p from k-0.52.11 to k-0.52.12 to fix build problems on IOS platform.
Adds tendermint protocol support on add_delegation RPC, and extends tendermint transaction history implementation to support delegation transactions.
We now enforce fixed-length byte arrays instead of indexing slices.  
This prevents unhandled panics when incoming slices are too short.

- Replaced slice indexing with safe fixed-size array creation.
- Removed methods that relied on unchecked slice indexing.
- Ensured each code path now handles invalid lengths gracefully.

Closes #2275
Refactor event streaming to support dynamic client subscriptions over RPC using a unified StreamingManager. The StreamingManager now orchestrates background streamers by initializing a streamer when a client activates it via the RPC API and shutting it down when no longer needed. Legacy fee estimator endpoints have been replaced with streaming RPC methods, and new task manager RPCs for BCH and Tendermint have been added. Additionally, event stream configuration has been migrated from static JSON settings to runtime API initialization for improved flexibility.
…2333)

This fixes `task::withdraw::init` for non-trezor utxo withdraws as it was failing with "error_data": "NoTrezorDeviceAvailable". It also allows the user to withdraw from any address in the HD wallet using `task::withdraw::init` instead of only the activated address.
Adds tendermint protocol support on remove_delegation RPC, and extends tendermint transaction history implementation to support undelegate transactions.
laruh and others added 3 commits February 8, 2025 16:04
)

This commit also provides EthCoin support in kickstart handler for taker and maker swaps #2300
This commit provides swap protocol versioning with a fallback to legacy swap protocol if any of the swap parties uses it.
Alrighttt and others added 5 commits February 12, 2025 20:21
…2354)

This commit does the following:
- Removes TakerSwapMakerCoin and MakerSwapTakerCoin traits and moves their methods to SwapOps
- Implements a default implementation for all WatcherOps methods.
- Implements default implementations for lightning network specific methods.
- Removes dead code SwapOps::check_tx_signed_by_pub and related function, utxo_common::check_all_inputs_signed_by_pub
…2353)

In addition to maintaining legacy compatibility for negotiation messages, this commit also uses serde rename instead of alias for `TakerSwapData::maker_pubkey` and `MakerSwapData::taker_pubkey` to fix p2p backward compatibility when serializing to old nodes.
Sepolia nodes configured in some tests were down. This commit adds a couple of running nodes.
Before this commit, `get_wallet_names` returned not only `*.dat` filenames from `db_root` as wallet names but also directories, to fix this `filter_files_by_extension` function was fixed to return only files.
shamardy and others added 3 commits February 20, 2025 01:19
This commit disables some unstable tests to make CI green again. The disabled tests have been moved to related issues and assigned a priority so they can be reintroduced again.
This allows rpcport value of 0 to be used within the config. This is the standard way of indicating "use any available port".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants