Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve tendermint withdraws #15

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Fix and improve tendermint withdraws #15

wants to merge 4 commits into from

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Nov 27, 2024

This PR adds a warning for Tendermint withdrawals, and adjusts the layout of the send form to include optional IBC channel ID input.

To Test:

  • Login and go to send some Tendermint coins
  • See warnings about IBC transfers to CEX
  • Send tendermint coin with non-IBC transfer (same chain/address format)
  • Send tendermint coin with IBC transfer but without custom IBC channel
  • Send tendermint coin with IBC transfer and with custom IBC channel
  • Confirm link to IBC channel info working
  • Test transactions with some other coins to confirm no regression (with/without custom fees & memos)

@smk762 smk762 added bug Something isn't working P0 Major bug to be fixed labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewDelaney AndrewDelaney Awaiting requested review from AndrewDelaney

@cipig cipig Awaiting requested review from cipig

@shamardy shamardy Awaiting requested review from shamardy

@ShantanuSharma9873 ShantanuSharma9873 Awaiting requested review from ShantanuSharma9873

Assignees
No one assigned
Labels
bug Something isn't working P0 Major bug to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smk762