Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combined PR for jmj refactoring #559

Merged
merged 236 commits into from
Jan 29, 2023
Merged

Combined PR for jmj refactoring #559

merged 236 commits into from
Jan 29, 2023

Conversation

dimxy
Copy link
Collaborator

@dimxy dimxy commented Sep 5, 2022 •
edited by tonymorony
Loading

jmjatlanta and others added 30 commits June 1, 2021 06:44
@jmjatlanta
allow help text even during node warmup
0278350
@jmjatlanta
wrap test chain funcs into class
26843c9
@jmjatlanta
document chainparams
fd09a2d
@jmjatlanta
document KOMODO_CONNECTING
a305097
@jmjatlanta
more documentation
c3ebdba
@jmjatlanta
clean up of db open code
c3def98
@jmjatlanta
fix hang on shutdown
165bb0f
@jmjatlanta
documentation of notarisationdb
16a3254
@jmjatlanta
fix vector initialization lists
4d0063f
@jmjatlanta
Merge branch 'dev' into jmj_testutils
803f247
@jmjatlanta
Merge branch 'dev'
684c275
@jmjatlanta
Find calls to CChain that are not locked
7d7eabb
@jmjatlanta
Add locks of cs_main
0cba296
@jmjatlanta
Add AssertLockHeld to komodo_xxx
186661c 
Only those that use chainActive
@jmjatlanta
lock cs_main for TestBlockValidity
777ee02
@jmjatlanta
cs_main already locked
eb1f5fe
@jmjatlanta
Upgrade threadsafety.h to clang 13
5fb10cd
@jmjatlanta
Add annotations to CChain
b06e900
@jmjatlanta
fix clang warnings
93218bf
@jmjatlanta
Fix return value of is_STAKED
f8f5cee
@jmjatlanta
Fix haraka warnings
417f5c3
@jmjatlanta
fix ASSETCHAINS_ENDSUBSIDY
59fb0f9
@jmjatlanta
Fix more clang warnings
72b8022
@jmjatlanta
Increase heir test timeout
eb2a18c
@jmjatlanta
test komodo_notarysinit
a29cc24
@jmjatlanta
Addl testing komodo_notarysinit
0be5fca
@jmjatlanta
code cleanup
549db0b
@jmjatlanta
code cleanup and comments
4247895
@dimxy
wait for mining threads to stop
acd2b3b
@dimxy
convert staking array to vector (to correctly destroy members) and ma…
24f7d50 
…ke it thread_local
DeckerSU
DeckerSU requested changes Sep 14, 2022
View reviewed changes
Copy link

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too early. Found one mistake, will push the fix soon.

DeckerSU and others added 4 commits September 15, 2022 22:10
@DeckerSU
Pr559 add (#128)
fa2d133 
* fix function(s) invokations after inaccurate merge branches

* fix treating std as a label, name it's a variable of std::string type
@dimxy
more old marmara code removed
979abb1
@dimxy
hush net commission code removed
005df66
@dimxy
more pegs code removed
ba73fd3
@dimxy dimxy mentioned this pull request Sep 16, 2022
Closed
This was referenced Oct 12, 2022
Closed
Closed
Closed
DeckerSU
DeckerSU previously approved these changes Oct 14, 2022
View reviewed changes
Copy link

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for dev branch.

@ca333 ca333 self-assigned this Oct 16, 2022
@DeckerSU DeckerSU mentioned this pull request Oct 17, 2022
Merged
@dimxy
Copy link
Collaborator Author

dimxy commented Dec 12, 2022

as we agreed with Decker and Tony I added a few commits with tests for komodo interest
(plz note I changed two retcodes in main.cpp if komodo_interest_validate failed, for the tests to work)

@ca333 ca333 merged commit d98ae09 into KomodoPlatform:dev Jan 29, 2023
This was referenced Mar 29, 2023
Closed
Closed
Closed
who-biz pushed a commit to who-biz/komodo that referenced this pull request Jul 29, 2024
@Asherda
Merge pull request KomodoPlatform#559 from Asherda/release-v1.1.2
65f766d 
Release v1.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheComputerGenie TheComputerGenie TheComputerGenie left review comments

@ca333 ca333 ca333 approved these changes

@DeckerSU DeckerSU DeckerSU left review comments

Assignees

@ca333 ca333

Labels
under test/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimxy @DeckerSU @ca333 @TheComputerGenie @jmjatlanta