Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comments to some dpow related code #583

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

dimxy
Copy link
Collaborator

@dimxy dimxy commented Apr 7, 2023

While studying komodo dpow code I added some comments for important dpow code, to memorise my findings and provide info for other developers.

@dimxy dimxy requested review from DeckerSU and smk762 April 7, 2023 09:44
smk762
smk762 previously approved these changes May 19, 2023
Copy link

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks, this helps demystify the code a bit.

ca333
ca333 previously approved these changes May 29, 2023
DeckerSU
DeckerSU previously approved these changes Jul 17, 2023
DeckerSU added a commit to DeckerSU/KomodoOcean that referenced this pull request Jul 17, 2023
These are cosmetic changes that will allow us to cherry-pick
the changes from KomodoPlatform/komodo#583
into our codebase without any conflicts. However, this commit
only includes one missed change, which is moving hwmheight
out of komodo_connectblock to allow testing. This change was
introduced by jmj:

https://github.com/KomodoPlatform/komodo/blob/156dba60184c07d0781a57d5b5005b8f3dba0c98/src/komodo.cpp#L627-L637
DeckerSU added a commit to DeckerSU/KomodoOcean that referenced this pull request Jul 17, 2023
Port of PR#583 KomodoPlatform/komodo#583
with squashing all related commits into one.
@ca333
Copy link

ca333 commented Jan 26, 2024

plz resolve conflict cc @dimxy

@dimxy dimxy dismissed stale reviews from DeckerSU, ca333, and smk762 via 0aac607 January 26, 2024 19:13
@dimxy
Copy link
Collaborator Author

dimxy commented Jan 27, 2024

conflicts resolved in komodo.cpp

@ca333 ca333 changed the base branch from dev to codecomment January 29, 2024 10:45
@ca333 ca333 merged commit d1743d3 into KomodoPlatform:codecomment Jan 29, 2024
18 checks passed
who-biz pushed a commit to who-biz/komodo that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants