Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sever health / Status page #337

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Sever health / Status page #337

wants to merge 18 commits into from

Conversation

aidantrabs
Copy link
Member

@aidantrabs aidantrabs commented Jan 12, 2025 •
edited
Loading

Description

Setup health check view

Linked Issues

Testing

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@aidantrabs aidantrabs added enhancement New feature or request frontend Related to the frontend of the project backend Related to the backend of the project api Related to the backend routes and endpoints labels Jan 12, 2025
@aidantrabs aidantrabs added this to the Complete the project MVP milestone Jan 12, 2025
@aidantrabs aidantrabs self-assigned this Jan 12, 2025
AmirAgassi
AmirAgassi approved these changes Jan 12, 2025
View reviewed changes
backend/internal/v1/v1_health/healthcheck.go
CPU: struct {
Usage float64 `json:"usage"`
}{
Usage: 0, // TODO: implement actual CPU usage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like CPU usage graph 😢
We can use https://github.com/shirou/gopsutil to get it super ez too

Other than that, LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a public health page? idk if that much information is needed to have on the public. Hackers can basically time the cpu usage with requests lol but thats a stretch

juancwu
juancwu reviewed Jan 13, 2025
View reviewed changes
.github/workflows/deploy-dev-backend.yml
docker run -d \
--name $KUMA_CONTAINER \
--network=$NETWORK_NAME \
-p "3001:3001" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the first port to an ENV since we can have multiple apps running on the server and we can control the port via ENV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancwu juancwu juancwu left review comments

@AmirAgassi AmirAgassi AmirAgassi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@aidantrabs aidantrabs

Labels
api Related to the backend routes and endpoints backend Related to the backend of the project enhancement New feature or request frontend Related to the frontend of the project
Projects
SPUR Platform
Status: No status
Milestone
Complete the project MVP
Development

Successfully merging this pull request may close these issues.

[FE Feat] Create the system health status page
3 participants
@aidantrabs @AmirAgassi @juancwu