Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helpers) KONG_PORT_MAPS value for tls overrideServiceTarget port #1091

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mithunkrb
Copy link
Contributor

@mithunkrb mithunkrb commented Jun 16, 2024

What this PR does / why we need it:

Currently KONG_PORT_MAPS uses the acutal tls serviceTargetPort even if overrideServiceTarget port is specified. This PR addresses the same, it uses tls overrideServiceTarget value when overrideServiceTarget is given.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@mithunkrb mithunkrb requested a review from a team as a code owner June 16, 2024 17:52
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please run make test.golden.update to update golden tests manifests for this. Additionally please add a changelog entry for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants