feat: add konnect.controlPlaneID and remove konnect.runtimeGroupID #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
previously approved these changes
Jul 4, 2024
czeslavo
reviewed
Jul 4, 2024
Signed-off-by: Jintao Zhang <[email protected]> Co-authored-by: Grzegorz Burzyński <[email protected]>
tao12345666333
force-pushed
the
add-cpi-and-deprecate-rgi
branch
from
4d8bb79
to
788de34
Compare
tao12345666333
changed the title
randmonkey
reviewed
Jul 17, 2024
Signed-off-by: Jintao Zhang <[email protected]>
randmonkey
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As a follow-up to Kong/kubernetes-ingress-controller#4466
KIC has added a flag --konnect-control-plane-id and marked the --konnect-runtime-group-id as deprecated
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.