fix(kong): handle admin openid-connect correctly for Kong < 3.6.0 #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
fix/openid-below-360
branch
from
fc98cf6
to
acf4430
Compare
czeslavo
force-pushed
the
fix/openid-below-360
branch
from
acf4430
to
0142245
Compare
randmonkey
previously approved these changes
Jul 17, 2024
czeslavo
force-pushed
the
fix/openid-below-360
branch
from
0142245
to
2735d5b
Compare
pmalek
approved these changes
Aug 9, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ensures that
KONG_ADMIN_GUI_SESSION_CONFis set when Kong version is below 3.6.0 and Admin RBAC is enabled. After recent changes that adapted to 3.6.0 no longer requiringKONG_ADMIN_GUI_SESSION_CONF, the chart stopped correctly handling older versions. This fixes that.Which issue this PR fixes
Issue reported by @yankun-li-kong.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.