Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing load balancer values #1116

Merged

Conversation

FedericoAntoniazzi
Copy link
Contributor

What this PR does / why we need it:

There were missing values in the default values.yaml file, which required visiting the implementation for discovering how to configure the proxy Service.
This PR reports those values in the default values.yaml file.

Special notes for your reviewer:

Checklist

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@FedericoAntoniazzi FedericoAntoniazzi requested a review from a team as a code owner August 15, 2024 21:51
@CLAassistant
Copy link

CLAassistant commented Aug 15, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably want to run make test.golden.update to update the golden files for tests

charts/kong/values.yaml Outdated Show resolved Hide resolved
charts/kong/CHANGELOG.md Outdated Show resolved Hide resolved
@FedericoAntoniazzi
Copy link
Contributor Author

You'll probably want to run make test.golden.update to update the golden files for tests

Hi @pmalek. I ran make test.golden.update but there are no changes. everything seems to be okay

pmalek
pmalek previously approved these changes Oct 1, 2024
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please rebase on top of latest changes in main.

@FedericoAntoniazzi
Copy link
Contributor Author

Hi @pmalek, thanks for your review and support!
I rebased the commits on top of main.

@pmalek pmalek merged commit 46c2fa0 into Kong:main Oct 2, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants