-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing load balancer values #1116
Missing load balancer values #1116
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll probably want to run make test.golden.update
to update the golden files for tests
Hi @pmalek. I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Please rebase on top of latest changes in main
.
Do not set loadBalancerIP since the field was deprecated in k8s v1.24 Co-authored-by: Patryk Małek <[email protected]>
949d5d7
to
5e03cc1
Compare
Hi @pmalek, thanks for your review and support! |
What this PR does / why we need it:
There were missing values in the default values.yaml file, which required visiting the implementation for discovering how to configure the proxy Service.
This PR reports those values in the default values.yaml file.
Special notes for your reviewer:
Checklist
main
branch.