Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specifically set issuer ref group name #1128

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

kamontat
Copy link
Contributor

What this PR does / why we need it:

This is the explicit group for cert-manager Issuer/ClusterIssuer.
On my use case is we set default issuer group to something different than default cert-manager.io

Special notes for your reviewer:

Checklist

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@kamontat kamontat requested a review from a team as a code owner September 10, 2024 16:45
@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good 👍

Do you mind adding a changelog entry for this?

@kamontat
Copy link
Contributor Author

@pmalek Added.

@pmalek pmalek merged commit 3def0d5 into Kong:main Oct 1, 2024
33 checks passed
@kamontat kamontat deleted the patch-1 branch October 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants