Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kong): add metrics Service for ingress controller exposed metrics #1134

Merged

Conversation

thameezb
Copy link
Contributor

What this PR does / why we need it:

Correctly adds in ports to the KIC webhook service so that the servicemonitor can correctly match

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@thameezb thameezb requested a review from a team as a code owner September 23, 2024 21:32
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@thameezb thameezb changed the title fix: kic correctly configure webhook for KIC servicemonitor fix: correctly configure webhook for KIC servicemonitor Sep 23, 2024
@thameezb thameezb force-pushed the fix-kic-servicemonitor-ingress-controller-metrics branch 2 times, most recently from 5e11a12 to 3d900fc Compare September 27, 2024 10:13
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

I believe this is a nice addition. I'd consider adding a separate Service which would only expose the metrics port.

LMKWYT

charts/kong/templates/admission-webhook.yaml Outdated Show resolved Hide resolved
@thameezb thameezb force-pushed the fix-kic-servicemonitor-ingress-controller-metrics branch from 3d900fc to 811015c Compare October 10, 2024 13:14
@thameezb thameezb force-pushed the fix-kic-servicemonitor-ingress-controller-metrics branch from 811015c to 7c6bc60 Compare October 10, 2024 13:16
@thameezb thameezb requested a review from pmalek October 10, 2024 13:16
charts/kong/CHANGELOG.md Outdated Show resolved Hide resolved
@pmalek pmalek changed the title fix: correctly configure webhook for KIC servicemonitor feat(kong): add metrics Service for ingress controller exposed metrics Oct 11, 2024
@pmalek pmalek enabled auto-merge (squash) October 11, 2024 11:50
@pmalek pmalek merged commit 76852b1 into Kong:main Oct 11, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants