-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kong): add metrics Service for ingress controller exposed metrics #1134
feat(kong): add metrics Service for ingress controller exposed metrics #1134
Conversation
|
5e11a12
to
3d900fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
I believe this is a nice addition. I'd consider adding a separate Service
which would only expose the metrics port.
LMKWYT
3d900fc
to
811015c
Compare
fix: EOF
811015c
to
7c6bc60
Compare
What this PR does / why we need it:
Correctly adds in ports to the KIC webhook service so that the servicemonitor can correctly match
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
main
branch.