Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hpa): add support for custom annotations on hpa #1239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GyunCho
Copy link

@GyunCho GyunCho commented Jan 24, 2025

What this PR does / why we need it:

This PR adds support for custom annotations on HPA.
Custom annotations on HPA can be useful because by using annotations field, we can set things like ArgoCD sync wave that controls the order of installations via ArgoCD. Related Argo CD Doc

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@GyunCho GyunCho requested a review from a team as a code owner January 24, 2025 18:53
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@GyunCho GyunCho changed the title Remotes/origin/hpa annotation feat(hpa): add support for custom annotations on hpa Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants