Gateway audit logs #596
Merged
Gateway audit logs #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diana <[email protected]>
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Diana <[email protected]>
Signed-off-by: Diana <[email protected]>
Signed-off-by: Diana <[email protected]>
lmilan
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Looks good! I think the way you reorganized the info makes a lot more sense, and the table is a lot easier to read than the existing docs. I left a couple of comments:
- I would add descriptions for everything in the table, for consistency and to make sure it doesn't look like something is missing.
- There's a possible error in the
Database entity changesrow, of the table
Co-authored-by: Lucie Milan <[email protected]>
Signed-off-by: Diana <[email protected]>
lmilan
approved these changes
Mar 5, 2025
Co-authored-by: Lucie Milan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #460
Preview Links
https://deploy-preview-596--kongdeveloper.netlify.app/gateway/audit-logs/
(added a tile) https://deploy-preview-596--kongdeveloper.netlify.app/gateway/security/
stub issues created: #604
Notes for reviewers
I did change how the content was formatted. If you could look over the original doc (https://docs.konghq.com/gateway/latest/kong-enterprise/audit-log/) and check that I made the right choices.
Checklist