Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppDynamics plugin #674

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

AppDynamics plugin #674

wants to merge 5 commits into from

Conversation

cloudjumpercat
Copy link
Contributor

@cloudjumpercat cloudjumpercat commented Mar 12, 2025

Description

Fixes #658

Preview Links

https://deploy-preview-674--kongdeveloper.netlify.app/plugins/app-dynamics/

Questions for reviewers

  • I didn't convert the intro to a how to since it involves Linux (and I've never worked with VMs) and we don't really have any info about where to find the values in AppDynamic to populate the environment variables. TL;DR: I think I can figure it out, but it's going to take more time than I think we should set aside for this in the migration. I can create a post-GA issue for it.
  • I removed the "supported platforms" section from the original since AppDynamics covers the details in the doc I linked and I'm not sure we want to repeat all the details about glibc 2.5+ etc. Thoughts?

Checklist

  • Every page is page one.
  • Tested how-to docs. If not, note why here. I tested that the example worked
  • All pages contain metadata.
  • Updated sources.yaml. For more info, review track docs changes
  • Any new docs link to existing docs.
  • All autogenerated instructions render correctly (API, decK, Konnect, Kong Manager).
  • Style guide (capitalized gateway entities, placeholder URLs) implemented correctly.

Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for kongdeveloper ready!

Name Link
🔨 Latest commit f486c52
🔍 Latest deploy log https://app.netlify.com/sites/kongdeveloper/deploys/67d1ef26354fdf0008fb9556
😎 Deploy Preview https://deploy-preview-674--kongdeveloper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Diana <[email protected]>
@cloudjumpercat cloudjumpercat marked this pull request as ready for review March 12, 2025 19:53
@cloudjumpercat cloudjumpercat requested a review from a team as a code owner March 12, 2025 19:53
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rename this page to something like enable-app-dynamics.yaml. Even if there's nothing specific to configure, that makes a better URL than /examples/example.

requirements:
- "Before using the plugin, download and install the AppDynamics C/C++ Application Agent and SDK on [Linux](https://docs.appdynamics.com/appd/23.x/latest/en/application-monitoring/install-app-server-agents/c-c++-sdk/install-the-c-c++-sdk-on-linux) or [Windows](https://docs.appdynamics.com/appd/23.x/latest/en/application-monitoring/install-app-server-agents/c-c++-sdk/install-the-c-c++-sdk-on-windows) on the machine or within the container running {{site.base_gateway}}."
- "Set `plugins=bundled,app-dynamics` in [`kong.conf`](/gateway/configuration/) before starting {{site.base_gateway}}"
- "Configure the AppDynamic plugin [environment variables](/plugins/app-dynamics/#plugin-configuration)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "Configure the AppDynamic plugin [environment variables](/plugins/app-dynamics/#plugin-configuration)"
- "Configure the AppDynamics plugin [environment variables](/plugins/app-dynamics/#plugin-configuration)"

Comment on lines 32 to 33
- analytics
- monitoring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- analytics
- monitoring
- analytics-monitoring
tags:
- analytics
- monitoring

The category expects analytics-monitoring to sort the plugins in the right place in the plugin hub: https://deploy-preview-674--kongdeveloper.netlify.app/plugins/?category=analytics-monitoring

You can add these add individual tags though.


* **Package install:** Set `plugins=bundled,app-dynamics` in [`kong.conf`](/gateway/configuration/) before starting {{site.base_gateway}}
* **Docker:** Set `export KONG_PLUGINS=bundled,app-dynamics` in the environment
* **Kubernetes:** Set `KONG_PLUGINS=bundled,app-dynamics` using these instructions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are "these instructions"?

for more information about the configuration parameters.

{:.info}
> All non-default environment variables in the table **must** be set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make them required instead, and label them that way?

Comment on lines +112 to +115
| `KONG_APPD_CONTROLLER_CERTIFICATE_FILE` | Path to a self-signed certificate file. For example, `/etc/kong/certs/ca-certs.pem`. <br><br>_Available starting in {{site.base_gateway}} 3.4.3.3_ | String | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_DIR` | Path to a certificate directory. For example, `/etc/kong/certs/`. <br><br> _Available starting in {{site.base_gateway}} 3.4.3.3_ | String | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_FILE` | Path to a self-signed certificate file. For example, `/etc/kong/certs/ca-certs.pem`. <br><br>_Available starting in {{site.base_gateway}} 3.6.x_ | String | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_DIR` | Path to a certificate directory. For example, `/etc/kong/certs/`. <br><br>_Available starting in {{site.base_gateway}} 3.6.x_ | String | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `KONG_APPD_CONTROLLER_CERTIFICATE_FILE` | Path to a self-signed certificate file. For example, `/etc/kong/certs/ca-certs.pem`. <br><br>_Available starting in {{site.base_gateway}} 3.4.3.3_ | String | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_DIR` | Path to a certificate directory. For example, `/etc/kong/certs/`. <br><br> _Available starting in {{site.base_gateway}} 3.4.3.3_ | String | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_FILE` | Path to a self-signed certificate file. For example, `/etc/kong/certs/ca-certs.pem`. <br><br>_Available starting in {{site.base_gateway}} 3.6.x_ | String | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_DIR` | Path to a certificate directory. For example, `/etc/kong/certs/`. <br><br>_Available starting in {{site.base_gateway}} 3.6.x_ | String | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_FILE` | Path to a self-signed certificate file. For example, `/etc/kong/certs/ca-certs.pem`. <br><br>_Available starting in {{site.base_gateway}} 3.4.3.3_ | String | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_DIR` | Path to a certificate directory. For example, `/etc/kong/certs/`. <br><br> _Available starting in {{site.base_gateway}} 3.4.3.3_ | String | |

I can't see any difference between these. I'm guessing it was probably a backport that created some dupe table entries/version tags.


## Agent logging

The AppDynamics agent sorts log information into separate log files, independent of {{site.base_gateway}}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The AppDynamics agent sorts log information into separate log files, independent of {{site.base_gateway}}.
The AppDynamics agent sorts log information into separate log files, independent of {{site.base_gateway}} logs.

## AppDynamics node name considerations

The AppDynamics plugin sets the `KONG_APPD_NODE_NAME` to the local
host name by default, which typically reflects the container ID of the containerized
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
host name by default, which typically reflects the container ID of the containerized
hostname by default, which typically reflects the container ID of the containerized

The AppDynamics plugin sets the `KONG_APPD_NODE_NAME` to the local
host name by default, which typically reflects the container ID of the containerized
application. Multiple instances of the AppDynamics agent must use
different node names, and one agent must exists for each of {{site.base_gateway}}'s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
different node names, and one agent must exists for each of {{site.base_gateway}}'s
different node names, and one agent must exist for each of {{site.base_gateway}}'s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppDynamics plugin
2 participants