-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppDynamics plugin #674
base: main
Are you sure you want to change the base?
AppDynamics plugin #674
Conversation
Signed-off-by: Diana <[email protected]>
Signed-off-by: Diana <[email protected]>
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Diana <[email protected]>
Signed-off-by: Diana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rename this page to something like enable-app-dynamics.yaml
. Even if there's nothing specific to configure, that makes a better URL than /examples/example
.
requirements: | ||
- "Before using the plugin, download and install the AppDynamics C/C++ Application Agent and SDK on [Linux](https://docs.appdynamics.com/appd/23.x/latest/en/application-monitoring/install-app-server-agents/c-c++-sdk/install-the-c-c++-sdk-on-linux) or [Windows](https://docs.appdynamics.com/appd/23.x/latest/en/application-monitoring/install-app-server-agents/c-c++-sdk/install-the-c-c++-sdk-on-windows) on the machine or within the container running {{site.base_gateway}}." | ||
- "Set `plugins=bundled,app-dynamics` in [`kong.conf`](/gateway/configuration/) before starting {{site.base_gateway}}" | ||
- "Configure the AppDynamic plugin [environment variables](/plugins/app-dynamics/#plugin-configuration)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "Configure the AppDynamic plugin [environment variables](/plugins/app-dynamics/#plugin-configuration)" | |
- "Configure the AppDynamics plugin [environment variables](/plugins/app-dynamics/#plugin-configuration)" |
- analytics | ||
- monitoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- analytics | |
- monitoring | |
- analytics-monitoring | |
tags: | |
- analytics | |
- monitoring |
The category expects analytics-monitoring
to sort the plugins in the right place in the plugin hub: https://deploy-preview-674--kongdeveloper.netlify.app/plugins/?category=analytics-monitoring
You can add these add individual tags though.
|
||
* **Package install:** Set `plugins=bundled,app-dynamics` in [`kong.conf`](/gateway/configuration/) before starting {{site.base_gateway}} | ||
* **Docker:** Set `export KONG_PLUGINS=bundled,app-dynamics` in the environment | ||
* **Kubernetes:** Set `KONG_PLUGINS=bundled,app-dynamics` using these instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are "these instructions"?
for more information about the configuration parameters. | ||
|
||
{:.info} | ||
> All non-default environment variables in the table **must** be set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make them required
instead, and label them that way?
| `KONG_APPD_CONTROLLER_CERTIFICATE_FILE` | Path to a self-signed certificate file. For example, `/etc/kong/certs/ca-certs.pem`. <br><br>_Available starting in {{site.base_gateway}} 3.4.3.3_ | String | | | ||
| `KONG_APPD_CONTROLLER_CERTIFICATE_DIR` | Path to a certificate directory. For example, `/etc/kong/certs/`. <br><br> _Available starting in {{site.base_gateway}} 3.4.3.3_ | String | | | ||
| `KONG_APPD_CONTROLLER_CERTIFICATE_FILE` | Path to a self-signed certificate file. For example, `/etc/kong/certs/ca-certs.pem`. <br><br>_Available starting in {{site.base_gateway}} 3.6.x_ | String | | | ||
| `KONG_APPD_CONTROLLER_CERTIFICATE_DIR` | Path to a certificate directory. For example, `/etc/kong/certs/`. <br><br>_Available starting in {{site.base_gateway}} 3.6.x_ | String | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `KONG_APPD_CONTROLLER_CERTIFICATE_FILE` | Path to a self-signed certificate file. For example, `/etc/kong/certs/ca-certs.pem`. <br><br>_Available starting in {{site.base_gateway}} 3.4.3.3_ | String | | | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_DIR` | Path to a certificate directory. For example, `/etc/kong/certs/`. <br><br> _Available starting in {{site.base_gateway}} 3.4.3.3_ | String | | | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_FILE` | Path to a self-signed certificate file. For example, `/etc/kong/certs/ca-certs.pem`. <br><br>_Available starting in {{site.base_gateway}} 3.6.x_ | String | | | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_DIR` | Path to a certificate directory. For example, `/etc/kong/certs/`. <br><br>_Available starting in {{site.base_gateway}} 3.6.x_ | String | | | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_FILE` | Path to a self-signed certificate file. For example, `/etc/kong/certs/ca-certs.pem`. <br><br>_Available starting in {{site.base_gateway}} 3.4.3.3_ | String | | | |
| `KONG_APPD_CONTROLLER_CERTIFICATE_DIR` | Path to a certificate directory. For example, `/etc/kong/certs/`. <br><br> _Available starting in {{site.base_gateway}} 3.4.3.3_ | String | | |
I can't see any difference between these. I'm guessing it was probably a backport that created some dupe table entries/version tags.
|
||
## Agent logging | ||
|
||
The AppDynamics agent sorts log information into separate log files, independent of {{site.base_gateway}}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AppDynamics agent sorts log information into separate log files, independent of {{site.base_gateway}}. | |
The AppDynamics agent sorts log information into separate log files, independent of {{site.base_gateway}} logs. |
## AppDynamics node name considerations | ||
|
||
The AppDynamics plugin sets the `KONG_APPD_NODE_NAME` to the local | ||
host name by default, which typically reflects the container ID of the containerized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
host name by default, which typically reflects the container ID of the containerized | |
hostname by default, which typically reflects the container ID of the containerized |
The AppDynamics plugin sets the `KONG_APPD_NODE_NAME` to the local | ||
host name by default, which typically reflects the container ID of the containerized | ||
application. Multiple instances of the AppDynamics agent must use | ||
different node names, and one agent must exists for each of {{site.base_gateway}}'s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
different node names, and one agent must exists for each of {{site.base_gateway}}'s | |
different node names, and one agent must exist for each of {{site.base_gateway}}'s |
Description
Fixes #658
Preview Links
https://deploy-preview-674--kongdeveloper.netlify.app/plugins/app-dynamics/
Questions for reviewers
Checklist