Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm): re-enable Lua DNS resolver for proxy-wasm #13363

Closed
wants to merge 1 commit into from

Conversation

flrgh
Copy link
Contributor

@flrgh flrgh commented Jul 11, 2024

Summary

This was previously disabled in 9a5d48b (#12825) due to shortcomings of the underlying ngx_wasm_module Lua execution model, which has since been fixed and merged into master (19ee6a9).

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com

Issue reference

KAG-4671

@github-actions github-actions bot added core/configuration cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jul 11, 2024
@flrgh flrgh force-pushed the fix/enable-proxy-wasm-lua-dns-resolver branch from a670bc8 to 7e3f0b6 Compare July 11, 2024 17:29
@flrgh flrgh requested review from brentos and locao July 11, 2024 17:46
@flrgh
Copy link
Contributor Author

flrgh commented Jul 11, 2024

Going to hold off on this for now.

@flrgh flrgh closed this Jul 11, 2024
@flrgh flrgh deleted the fix/enable-proxy-wasm-lua-dns-resolver branch July 11, 2024 17:53
@flrgh
Copy link
Contributor Author

flrgh commented Jul 18, 2024

See also: Kong/ngx_wasm_module#574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/configuration size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant