Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ktableview): horizontal scroll overlay indicators [KHCP-15221] #2629

Merged
merged 12 commits into from
Mar 7, 2025

Conversation

portikM
Copy link
Member

@portikM portikM commented Feb 25, 2025

@portikM portikM self-assigned this Feb 25, 2025
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit ea6a3cd
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/67c8aecb7529df000806c5b7
😎 Deploy Preview https://deploy-preview-2629--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit ea6a3cd
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/67c8aecb00efd90008a48b76
😎 Deploy Preview https://deploy-preview-2629--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not playing nice with sticky header.

  • Something not working right - lost the header and bottom scrollbar
    image
    image

  • Too many scrollbars
    image
    image

@portikM
Copy link
Member Author

portikM commented Mar 5, 2025

Not playing nice with sticky header.

  • Something not working right - lost the header and bottom scrollbar
    image
    image
  • Too many scrollbars
    image
    image

The double scrollbar is caused by the resizable container. I've confirmed it looks and functions correctly on mobile in small spaces by resizing the browser window and even on mobile.

IMG_0307

Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@portikM portikM merged commit 5782168 into main Mar 7, 2025
10 checks passed
@portikM portikM deleted the fix/khcp-15221-ktableview-horizontal-scroll branch March 7, 2025 16:24
kongponents-bot pushed a commit that referenced this pull request Mar 7, 2025
## [9.22.3](v9.22.2...v9.22.3) (2025-03-07)

### Bug Fixes

* **ktableview:** horizontal scroll overlay indicators [KHCP-15221] ([#2629](#2629)) ([5782168](5782168))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.22.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kongponents-bot
Copy link
Collaborator

Preview package from this PR in consuming application

In consuming application project install preview version of kongponents generated by this PR:

@kong/kongponents@pr-2629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants