Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kpop, ktooltip): add offset prop [KHCP-15283] #2634

Merged
merged 6 commits into from
Mar 11, 2025

Conversation

portikM
Copy link
Member

@portikM portikM commented Mar 5, 2025

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-15283

Add offset prop in KPop and kpopAttributes prop in KTooltip (screenshots)

Screenshot 2025-03-05 at 1 23 37 PM
Screenshot 2025-03-05 at 1 23 54 PM

@portikM portikM self-assigned this Mar 5, 2025
@portikM portikM requested review from adamdehaven, jillztom, Justineo and a team as code owners March 5, 2025 18:18
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 5d2b38a
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/67ca006db3a03e00086725b8
😎 Deploy Preview https://deploy-preview-2634--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 5d2b38a
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/67ca006d7822b900084820c1
😎 Deploy Preview https://deploy-preview-2634--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM merged commit 56791ae into main Mar 11, 2025
10 checks passed
@portikM portikM deleted the fix/khcp-15283-kpop-offset-prop branch March 11, 2025 14:03
kongponents-bot pushed a commit that referenced this pull request Mar 11, 2025
# [9.23.0](v9.22.3...v9.23.0) (2025-03-11)

### Features

* **kpop, ktooltip:** add offset prop [KHCP-15283] ([#2634](#2634)) ([56791ae](56791ae))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kongponents-bot
Copy link
Collaborator

Preview package from this PR in consuming application

In consuming application project install preview version of kongponents generated by this PR:

@kong/kongponents@pr-2634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants