fix(klabel): required indicator icon not aligned properly [KM-1034] #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the required indicator bottom value did not include $kLabelRequiredDotSize to calculate
jw-foss
requested review from
adamdehaven,
jillztom,
Justineo and
a team
as code owners
|
|
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamdehaven
approved these changes
Mar 11, 2025
adamdehaven
deleted the
fix/label-required-dot-indicator-was-not-aligned-properly
branch
kongponents-bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
## [9.23.1](v9.23.0...v9.23.1) (2025-03-11) ### Bug Fixes * **klabel:** required indicator icon not aligned properly [KM-1034] ([#2640](#2640)) ([41a43ef](41a43ef))
|
🎉 This PR is included in version 9.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the required indicator bottom value did not include $kLabelRequiredDotSize to calculate
Summary
The value of the red dot
bottomdid not include the$kLabelRequiredDotSizeinto its calculation, this PR simply brings the value to the equation so that the red dot can be properly aligned with the label text.Screenshots