Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): popover attributes allow width #2641

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

portikM
Copy link
Member

@portikM portikM commented Mar 11, 2025

Summary

Allow width property in PopoverAttributes type for backward compatibility

@portikM portikM self-assigned this Mar 11, 2025
@portikM portikM requested a review from a team as a code owner March 11, 2025 15:06
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 495fe77
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/67d053d687eadc00087eb98c
😎 Deploy Preview https://deploy-preview-2641--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM changed the title fix(types): popover attributes backward compitibility fix(types): popover attributes backward compatibility Mar 11, 2025
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 495fe77
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/67d053d6d01576000827b800
😎 Deploy Preview https://deploy-preview-2641--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM changed the title fix(types): popover attributes backward compatibility fix(types): popover attributes allow width Mar 11, 2025
@portikM portikM enabled auto-merge (squash) March 11, 2025 16:19
Copy link
Member

@arashsheyda arashsheyda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@portikM portikM merged commit 52d9f6f into main Mar 11, 2025
10 checks passed
@portikM portikM deleted the fix/popover-attributes-backward-compatibility branch March 11, 2025 16:21
kongponents-bot pushed a commit that referenced this pull request Mar 11, 2025
## [9.23.2](v9.23.1...v9.23.2) (2025-03-11)

### Bug Fixes

* **types:** popover attributes allow width ([#2641](#2641)) ([52d9f6f](52d9f6f))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.23.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants