Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ktableview): row links tabindex [KHCP-15202] #2643

Merged
merged 1 commit into from
Mar 12, 2025
Merged

fix(ktableview): row links tabindex [KHCP-15202] #2643

merged 1 commit into from
Mar 12, 2025

Conversation

portikM
Copy link
Member

@portikM portikM commented Mar 11, 2025

Summary

Don't set tabindex on rows when rowLink prop is provided

@portikM portikM self-assigned this Mar 11, 2025
@portikM portikM requested review from adamdehaven, jillztom, Justineo and a team as code owners March 11, 2025 21:40
@portikM portikM enabled auto-merge (squash) March 11, 2025 21:40
@netlify Netlify
Copy link

netlify bot commented Mar 11, 2025 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 952d47e
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/67d0adcae647ea00085073e8
😎 Deploy Preview https://deploy-preview-2643--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 11, 2025

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 952d47e
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/67d0adcaa0783d0008c503f1
😎 Deploy Preview https://deploy-preview-2643--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mptap
mptap approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@mptap mptap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@portikM portikM merged commit 2fe2746 into main Mar 12, 2025
10 checks passed
@portikM portikM deleted the fix/khcp-15202-ktableview-row-tabindex branch March 12, 2025 17:05
kongponents-bot pushed a commit that referenced this pull request Mar 12, 2025
@semantic-release-bot
chore(release): 9.23.4 [skip ci]
9fdd3a7 
## [9.23.4](v9.23.3...v9.23.4) (2025-03-12)

### Bug Fixes

* **ktableview:** row links tabindex [KHCP-15202] ([#2643](#2643)) ([2fe2746](2fe2746))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.23.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kongponents-bot
Copy link
Collaborator

Preview package from this PR in consuming application

In consuming application project install preview version of kongponents generated by this PR:

@kong/kongponents@pr-2643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mptap mptap mptap approved these changes

@adamdehaven adamdehaven Awaiting requested review from adamdehaven adamdehaven is a code owner

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

@Justineo Justineo Awaiting requested review from Justineo Justineo is a code owner

Assignees

@portikM portikM

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portikM @kongponents-bot @mptap