Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove leftover ts-ignores #484

Merged
merged 1 commit into from
Apr 8, 2024
Merged

chore: remove leftover ts-ignores #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/vitals/ChartPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ const props = defineProps<{
const selectedTimeframe = computed(() => props.modelValue.timeframe?.value)
const selectedProductVersions = computed(() => props.modelValue.apiVersions?.value)
const timeseriesQueryTime = computed(() => new TimeseriesQueryTime(selectedTimeframe.value))
// @ts-ignore - The actual key name we want to extract is `value`
const productVersionsCacheKey = computed(() => selectedProductVersions.value.map(entry => entry.value).join('-') || '')
const appCacheKey = computed(() => `${productVersionsCacheKey.value}-${timeseriesQueryTime.value.startMs()}-${timeseriesQueryTime.value.endMs()}`)

Expand Down
2 changes: 0 additions & 2 deletions src/views/ProductShell.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ const deselectOperation = ref<boolean>(false)

const deprecatedWarning = helpText.productVersion.deprecatedWarningProduct

// @ts-ignore
const productStore = useProductStore()
const { product, documentTree, activeDocumentSlug, activeProductVersionId } = storeToRefs(productStore)

Expand Down Expand Up @@ -111,7 +110,6 @@ async function fetchDocumentTree () {
const requestOptions = {
productId: id
}
// @ts-ignore
// overriding the axios response because we're specifying what we're accepting above
if (productStore.product) {
const res = await documentationApi.listProductDocuments(requestOptions, {
Expand Down
Loading