Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog): conditionally add public labels header #560

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

andrewwylde
Copy link
Contributor

No description provided.

@andrewwylde andrewwylde requested a review from a team as a code owner December 5, 2024 18:23
@andrewwylde andrewwylde enabled auto-merge (squash) December 5, 2024 18:25
{ label: 'Title', key: 'title' },
{ label: 'Description', key: 'description' },
{ label: 'Latest Version', key: 'latestVersion' },
...(publicLabelsUIEnabled ? [{ label: 'Public Labels', key: 'publicLabels' }] : []),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the meat of this PR, as it conditionally adds the header, therefore not rendering the JSON when the flag evaluates to false.

@andrewwylde andrewwylde merged commit 7052ec9 into main Dec 5, 2024
9 checks passed
@andrewwylde andrewwylde deleted the feat/public-labels branch December 5, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants