feat: allow dynamically exposing diagnostics for multiple instances #7092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/kic-as-library #7092 +/- ##
=====================================================
Coverage ? 77.0%
=====================================================
Files ? 220
Lines ? 25159
Branches ? 0
=====================================================
Hits ? 19388
Misses ? 4773
Partials ? 998 ☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
feat/dynamic-diagnostics-server
branch
from
f36c68c to
268bf3d
Compare
czeslavo
force-pushed
the
feat/dynamic-diagnostics-server
branch
from
268bf3d to
16523dc
Compare
czeslavo
force-pushed
the
feat/dynamic-diagnostics-server
branch
from
16523dc to
407fb41
Compare
czeslavo
force-pushed
the
feat/dynamic-diagnostics-server
branch
2 times, most recently
from
391e806 to
e1f9eb9
Compare
czeslavo
force-pushed
the
feat/dynamic-diagnostics-server
branch
from
e1f9eb9 to
f37d74a
Compare
czeslavo
changed the title
programmer04
reviewed
Feb 7, 2025
czeslavo
force-pushed
the
feat/dynamic-diagnostics-server
branch
from
295d146 to
98f50fe
Compare
Co-authored-by: Jakub Warczarek <[email protected]>
czeslavo
force-pushed
the
feat/dynamic-diagnostics-server
branch
from
98f50fe to
4c29f45
Compare
programmer04
reviewed
Feb 7, 2025
Co-authored-by: Jakub Warczarek <[email protected]>
programmer04
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
multiinstace.DiagnosticsServerand integrates it withmultiinstace.Managerto register/unregister currently running instances and expose their config diagnostics data on/{instanceID}/debug/configendpoints.Which issue this PR fixes:
Part of #7042.