Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard-renderer): reduce required dependencies #1950

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adorack
Copy link
Contributor

@adorack adorack commented Feb 12, 2025

  • Move ajv to a dev dependency, since it's only used in the sandbox MA-3247
  • Don't require entities-shared since it's a large package that's only useful within Konnect MA-3246
    • Host apps will need to provide a fallback, potentially via alias.

Summary

Improve compatibility with downstream applications.
- Move `ajv` to a dev dependency, since it's only used in the sandbox [MA-3247]
- Don't require `entities-shared` since it's a large package that's only useful within Konnect [MA-3246]
  - Host apps will need to provide a fallback, potentially via alias.
@adorack adorack changed the title Fix/split 3 fix(dashboard-renderer): reduce required dependencies Feb 13, 2025
@adorack adorack marked this pull request as ready for review February 13, 2025 15:18
@adorack adorack requested review from kongponents-bot and a team as code owners February 13, 2025 15:18
@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/dashboard-renderer@pr-1950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants