Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add component tests for dashboard components #2020

Merged
merged 4 commits into from
Mar 13, 2025
Merged

fix: add component tests for dashboard components #2020

merged 4 commits into from
Mar 13, 2025

Conversation

filipgutica
Copy link
Contributor

@filipgutica filipgutica commented Mar 13, 2025 •
edited
Loading

@filipgutica filipgutica requested review from kongponents-bot and a team as code owners March 13, 2025 00:15
@filipgutica filipgutica force-pushed the fix/gridstack-layout-component-tests branch from 0027ad1 to 406d0d6 Compare March 13, 2025 00:17
@filipgutica filipgutica force-pushed the fix/gridstack-layout-component-tests branch from 68e9930 to c368514 Compare March 13, 2025 05:34
adorack
adorack requested changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@adorack adorack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to review.

adorack
adorack approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@adorack adorack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these look good -- thanks especially for testing the tile reordering code.

@filipgutica filipgutica merged commit 934742f into main Mar 13, 2025
8 checks passed
@filipgutica filipgutica deleted the fix/gridstack-layout-component-tests branch March 13, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adorack adorack adorack approved these changes

@kongponents-bot kongponents-bot Awaiting requested review from kongponents-bot kongponents-bot is a code owner

Assignees

@filipgutica filipgutica

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipgutica @adorack @ValeryG