Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 3306] Update signing flow with metadata #3937

Open
wants to merge 1 commit into
base: subwallet-dev
Choose a base branch
from

Conversation

tunghp2002
Copy link

No description provided.

@tunghp2002 tunghp2002 requested a review from nampc1 December 19, 2024 02:42
@tunghp2002 tunghp2002 self-assigned this Dec 19, 2024
@tunghp2002 tunghp2002 linked an issue Dec 19, 2024 that may be closed by this pull request
4 tasks
@saltict
Copy link

saltict commented Dec 19, 2024

🚀 Deployed on https://pr-3937--sw-web-runner.netlify.app

@saltict saltict temporarily deployed to pull request December 19, 2024 02:52 Inactive
if (!metadataV15.isEmpty) {
hexV15 = metadataV15.unwrap().toHex();
}
const [metadataHex, hexV15] = await Promise.all([
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a new store to metadataV15 and add new function to save.

metadata = this.#koniState.knownMetadata.find((meta: MetadataDef) =>
meta.genesisHash === payload.genesisHash);
const [apiMetadata, dbMetadata, dappMetadata] = await Promise.all([
{ metadata: this.#koniState.getSubstrateApi(chainInfo?.slug ?? '').metadata, source: MetadataSource.API },
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This metadata not updated after connect with chain

*/
metadata = this.#koniState.knownMetadata.find((meta: MetadataDef) =>
meta.genesisHash === payload.genesisHash);
const [apiMetadata, dbMetadata, dappMetadata] = await Promise.all([
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to get registry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update signing flow with metadata
3 participants