Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release resource file memory after deleting #483

Closed
wants to merge 1 commit into from

Conversation

Bl3nd
Copy link
Contributor

@Bl3nd Bl3nd commented Jan 14, 2024

Clear resource classes, class bytes, and files after deleting directory from resource list to clear memory. In response to issue #482.

@threefusii
Copy link

always forcing System.gc() may not be a good idea especially for a lot of RAM and slower processor single-core speed. maybe hide it behind an (enabled by default) option?

anyway, there's always -XX:+DisableExplicitGC

@Bl3nd
Copy link
Contributor Author

Bl3nd commented Jan 15, 2024

I totally understand the System.gc() concerns you have, I will try other ideas I can come up with.

@Bl3nd Bl3nd closed this Jan 15, 2024
@Bl3nd
Copy link
Contributor Author

Bl3nd commented Jan 15, 2024

Closed PR to further address memory issues when deleting a resource (for now). Even when deleting and clearing using the above code (without gc) it keeps the deleted ResourceContainer in memory and adds new instances using either reload or add.

@Konloch
Copy link
Owner

Konloch commented Jan 16, 2024

I pushed an update to help with this - aea66fe - this should resolve the reference issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants