Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indroduce SimpleBuildWrapper that runs and stops node. #133

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

KostyaSha
Copy link
Owner

@KostyaSha KostyaSha commented Mar 8, 2017

piece of #126


This change is Reviewable

No tasks executions internally.

Signed-off-by: Kanstantsin Shautsou <[email protected]>
@codecov-io
Copy link

codecov-io commented Mar 9, 2017

Codecov Report

Merging #133 into master will decrease coverage by -7.01%.
The diff coverage is 11.52%.

@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
- Coverage     32.45%   25.44%   -7.01%     
- Complexity      200      203       +3     
============================================
  Files            36       45       +9     
  Lines          1439     1851     +412     
  Branches        143      169      +26     
============================================
+ Hits            467      471       +4     
- Misses          915     1325     +410     
+ Partials         57       55       -2
Impacted Files Coverage Δ Complexity Δ
.../kostyasha/yad/queue/FlyweightCauseOfBlockage.java 0% <ø> (ø) 0 <0> (?)
...asha/yad/strategy/DockerOnceRetentionStrategy.java 12.9% <ø> (-6.46%) 3 <0> (-1)
...a/com/github/kostyasha/yad/DockerOfflineCause.java 0% <0%> (ø) 0 <0> (ø)
...ostyasha/yad/client/ClientBuilderForConnector.java 0% <0%> (ø) 0 <0> (ø)
...om/github/kostyasha/yad/commons/AbstractCloud.java 45.23% <0%> (-1.28%) 10 <0> (ø)
...yasha/yad/launcher/DockerComputerJNLPLauncher.java 22.83% <0%> (-1.17%) 14 <0> (-1)
...ha/yad/connector/CredentialsYADockerConnector.java 0% <0%> (ø) 0 <0> (?)
...ain/java/com/github/kostyasha/yad/DockerCloud.java 13.54% <0%> (-0.09%) 9 <0> (ø)
...kostyasha/yad/queue/SingleNodeCauseOfBlockage.java 0% <0%> (ø) 0 <0> (?)
...va/com/github/kostyasha/yad/DockerSlaveSingle.java 0% <0%> (ø) 0 <0> (?)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7d35e...a7abaac. Read the comment docs.

@KostyaSha KostyaSha merged commit 79692c1 into master Mar 9, 2017
@KostyaSha KostyaSha deleted the dockerWrapper branch April 3, 2017 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants