Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CONTRIBUTION.md to CONTRIBUTING.md #103

Closed
wants to merge 1 commit into from

Conversation

ariyonaty
Copy link

Description

In the effort of improving the state of the repo, this minor fix renames the contribution file from CONTRIBUTION.md to CONTRIBUTING.md, aligning with GitHub's Default Health File Convention. This also aligns with the majorly standardized convention employed by the majority of open-source repos.

Type of change

  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have maintained a clean commit history by using the necessary Git commands
  • I have checked that my code does not cause any merge conflicts

@Wahid7852
Copy link
Collaborator

Seriously...? This?
Where is the issue pointing out to this PR?

@ariyonaty
Copy link
Author

@Wahid7852 - There is no issue linked here, nor am I doing this for any "points", "levels", or GSSoC events.
Simply as I was poking around Hacktoberfest repos, noticed that the Github contribution guidelines section was not showing up - a result of the filename not following the convention laid out by Github and realized I can make the quick fix so that future viewers can have the more standardized experience.

Copy link
Collaborator

@techy4shri techy4shri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I appreciate you including a link to GitHub's Default Health File Convention, know that this repository is currently under GirlScript Summer of Code-Extended also, apart from hacktober-fest, which means that we follow a set of rules for accepting pull requests. Even as a simple PR in case this repository wasn't part of the program, you do not simply raise a PR unless stated by the maintainer.
You raise an issue first stating the problem and then raise a PR if you're assigned to that issue.

And seriously? Contributing.md?? That is not even a good name change....
Long story short: This PR is being rejected for not following the rules of the repo.

@techy4shri techy4shri closed this Oct 10, 2024
@ariyonaty ariyonaty deleted the patch-1 branch October 10, 2024 10:25
@techy4shri techy4shri added invalid This doesn't seem right wontfix This will not be worked on REJECTED Pull request rejected labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right REJECTED Pull request rejected wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants