Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve User Experience by Implementing Multi-Select #88 #111

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

fluid111
Copy link
Contributor

@fluid111 fluid111 commented Oct 10, 2024

Description

Currently it becomes confusing to navigate files for selection. Now users can use arrow keys to navigate files to select , they can see the size of files on CLI and added an extra prompt ensuring they selected the files they intended to delete. So that they will not accidentally delete the files they did not intended to .

Type of change

  • New feature (non-breaking change which adds functionality)

Closes #88

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have maintained a clean commit history by using the necessary Git commands
  • I have checked that my code does not cause any merge conflicts

Before
Screenshot 2024-10-11 082218
Screenshot 2024-10-11 082235

After
Screenshot 2024-10-11 082430

@fluid111
Copy link
Contributor Author

can you add label for hacktoberfest and gssoc before merging

@Wahid7852
Copy link
Collaborator

Can you share images of how will this be working?

@fluid111
Copy link
Contributor Author

Screenshot 2024-10-10 160116

Copy link
Collaborator

@techy4shri techy4shri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First and foremost, fill the PR description and all fields properly. Only then this PR will be reviewed. Those fields are for a purpose.

@fluid111
Copy link
Contributor Author

First and foremost, fill the PR description and all fields properly. Only then this PR will be reviewed. Those fields are for a purpose.

Can you check it if it is alright ?

@fluid111
Copy link
Contributor Author

fluid111 commented Oct 14, 2024

First and foremost, fill the PR description and all fields properly. Only then this PR will be reviewed. Those fields are for a purpose.

is there anything that i can improve, please let me know

@techy4shri
Copy link
Collaborator

First and foremost, fill the PR description and all fields properly. Only then this PR will be reviewed. Those fields are for a purpose.

is there anything that i can improve, please let me know

Not right now, let the PA review this and I will let you know if anything else is needed!

Copy link
Owner

@Kota-Karthik Kota-Karthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything LGTM!
even code is clean

@Kota-Karthik Kota-Karthik merged commit 7a9070a into Kota-Karthik:main Oct 14, 2024
2 checks passed
Copy link
Collaborator

@techy4shri techy4shri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good, thank you for contributing @fluid111 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve User Experience by Implementing Multi-Select
4 participants