-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebooks update #1085
base: master
Are you sure you want to change the base?
Notebooks update #1085
Conversation
} | ||
}, | ||
"source": [ | ||
"val df = DataFrame.readCsv(\n", | ||
"val df = DataFrame.readCSV(\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readCSV is deprecated in favor of readCsv in the next release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove your api key!
Please change this line to point to the dev notebooks as well :) and maybe, to make it easier for us and our users in the future, expand the README.md file for the examples module explaining that all notebooks use the latest stable version, while in the dev folder, we target the latest master/dev version :) Also, please add to the RELEASE_CHECK_LIST.md what to do with the notebooks (aka, move all dev versions to stable, create new dev versions) |
Why and how? |
We actually run the notebooks as part of our test suite (as mentioned in the examples/README.md) to check they still compile. This is done from |
Closes #992 .
Migrate netflix geo example to kandy-geo.