Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks update #1085

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Notebooks update #1085

wants to merge 3 commits into from

Conversation

AndreiKingsley
Copy link
Collaborator

Closes #992 .
Migrate netflix geo example to kandy-geo.

@Jolanrensen Jolanrensen self-requested a review March 5, 2025 11:41
}
},
"source": [
"val df = DataFrame.readCsv(\n",
"val df = DataFrame.readCSV(\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readCSV is deprecated in favor of readCsv in the next release

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove your api key!

@Jolanrensen Jolanrensen mentioned this pull request Mar 5, 2025
@Jolanrensen
Copy link
Collaborator

Jolanrensen commented Mar 7, 2025

Please change this line to point to the dev notebooks as well :) and maybe, to make it easier for us and our users in the future, expand the README.md file for the examples module explaining that all notebooks use the latest stable version, while in the dev folder, we target the latest master/dev version :)

Also, please add to the RELEASE_CHECK_LIST.md what to do with the notebooks (aka, move all dev versions to stable, create new dev versions)

@AndreiKingsley
Copy link
Collaborator Author

AndreiKingsley commented Mar 7, 2025

Please change this line to point to the dev notebooks as well :)

Why and how?

@Jolanrensen
Copy link
Collaborator

Why and how?

We actually run the notebooks as part of our test suite (as mentioned in the examples/README.md) to check they still compile. This is done from :core/src/test/jupyter. So, to keep this behavior, we should keep testing the dev notebooks. That way we'll know immediately when we make a change to the library which breaks our notebook examples :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update example notebooks with Kandy v0.8
2 participants