Pivot kdocs #1554
Pivot kdocs #1554
Conversation
| @ExcludeFromSources | ||
| interface OPERATION | ||
|
|
||
| /** |
There was a problem hiding this comment.
to make it clearer this is a comment about RECEIVER and not some KDoc to include somewhere else I'd use "gray" comments for arguments
| * | ||
| * ### Create [Pivot] | ||
| * | ||
| * [**`pivot`**][pivot]**`(`**`inward: `[`Boolean`][Boolean]**` = true) { `**`pivotColumns: `[`PivotColumnsSelector`][PivotColumnsSelector]**` }`** |
There was a problem hiding this comment.
` = true) { ` should likely be ` = true) { `
There was a problem hiding this comment.
remember the surrounding-space-trim rule
| * | ||
| * ### Reduce [Pivot] into [DataRow] | ||
| * | ||
| * [Pivot][Pivot]`.`[**`minBy`**][Pivot.minBy]**` { `**`column: `[`RowExpression`][RowExpression]**` }`** |
There was a problem hiding this comment.
` { ` is correct. Will be trimmed to <space>{<space>
**` }`** has one space too many at the start. It will not be trimmed since it doesn't start ánd end with a space
| * | ||
| * ### Aggregate [Pivot] into [DataRow] | ||
| * | ||
| * [Pivot][Pivot]`.`[**`count`**][Pivot.count]**`() `** |
There was a problem hiding this comment.
useless space after ()
| * `| `__`.`__[**`groupByOther`**][Pivot.groupByOther]**`()`** | ||
| * | ||
| * {@include [Indent]} | ||
| * ` \[ `__`.`__[**`default`**][PivotGroupBy.default]**`(`**`defaultValue`**`) `**`]` |
There was a problem hiding this comment.
how did you want this to render? The spaces at the start disappear in KDoc atm. If you wanted more indent, @include [DoubleIndent] :) but I don't think indent is needed here
Jolanrensen
left a comment
Jolanrensen
left a comment
There was a problem hiding this comment.
I'll review more tomorrow :)
Closes #1525