Change default Dokka Generator worker isolation to 'classloader' #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Context DGP must use the Worker API to run Dokka Generator in an isolated classpath. There are two available Worker modes: process isolation, and classloader isolation. Originally in Dokkatoo I chose process isolation because Dokka Generator can be a heavy process, and using a separate process makes it easier to specifically increase the memory only for Dokka. However, for DGPv2 we want to more closely match the behaviour of DGPv1, which runs Dokka Generator in the same Gradle build process. With classloader isolation configuring memory is also easier (just increase memory for the Gradle daemon). We also wanted to choose a default that 'just worked' for most project. In some large projects process isolation caused excessive memory usage (running both Dokka and Gradle in separate processes took a lot of system memory).
adam-enko
added
the
runner: Gradle plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KT-72859