Apple QoS support via donation #499
Conversation
|
Platform dependencies change diagram: https://docs.google.com/presentation/d/1JtQ5GsjDmhtPKCYkzxPwRp-fD58NiKMw4nIi85_M7kg/edit?usp=sharing |
There was a problem hiding this comment.
Great job!
I have a few essential comments on Apple-related implementation, and it's good to go. To avoid extra-round trips please take a look at new warnings produced by ./gradlew build.
I would also kindly ask (but I'll accept the CR without it) to align non-apple SynchronizedObject with the current implementation as well -- you can copy-paste it but remove QoS mentions, or you can make this code part of nativeMain with expect DonatingMonitor, whatever is easier. Having two different implementations going to be real PITA here
atomicfu/src/appleMain/kotlin/kotlinx/atomicfu/locks/Synchronized.kt
Outdated
Show resolved
Hide resolved
atomicfu/src/appleMain/kotlin/kotlinx/atomicfu/locks/Synchronized.kt
Outdated
Show resolved
Hide resolved
atomicfu/src/appleMain/kotlin/kotlinx/atomicfu/locks/Synchronized.kt
Outdated
Show resolved
Hide resolved
atomicfu/src/appleMain/kotlin/kotlinx/atomicfu/locks/Synchronized.kt
Outdated
Show resolved
Hide resolved
atomicfu/src/appleMain/kotlin/kotlinx/atomicfu/locks/Synchronized.kt
Outdated
Show resolved
Hide resolved
atomicfu/src/appleMain/kotlin/kotlinx/atomicfu/locks/Synchronized.kt
Outdated
Show resolved
Hide resolved
atomicfu/src/appleMain/kotlin/kotlinx/atomicfu/locks/Synchronized.kt
Outdated
Show resolved
Hide resolved
atomicfu/src/appleMain/kotlin/kotlinx/atomicfu/locks/Synchronized.kt
Outdated
Show resolved
Hide resolved
I checked the IDE for warnings and fixed the threadlocal package. Not sure about the redundant "public" modifiers? For some bits (forked from the compose implementation) I was not sure to which extent they were outdated or intended for some reason. Unfortunately,
SGTM but let me do this in a followup. |
|
Does this make sense? Not sure why the requested change is still highlighted -- it should be addressed in the updated branch.... |
|
I've run the remote build. In the meantime, PTAL at the malloc commentary |
Done. |
Addressing issue #462