Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KRPC-59 streamScoped has internal package #104

Merged
merged 1 commit into from
Jun 19, 2024
Merged

KRPC-59 streamScoped has internal package #104

merged 1 commit into from
Jun 19, 2024

Conversation

Mr3zee
Copy link
Collaborator

@Mr3zee Mr3zee commented Jun 19, 2024

Subsystem
Core

Problem Description
streamScoped and invokeOnStreamScopeCompletion public APIs were wrongly located in kotlinx.rpc.internal package.

Solution
Move to kotlinx.rpc package, deprecate old methods

@Mr3zee Mr3zee requested a review from e5l June 19, 2024 09:33
@Mr3zee Mr3zee self-assigned this Jun 19, 2024
@Mr3zee Mr3zee force-pushed the KRPC-59-stream-scoped-pkg branch 4 times, most recently from 8f0fbe7 to 7659308 Compare June 19, 2024 12:05
e5l
e5l approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I think we need to check if we can avoid using top-level functions for that

@Mr3zee Mr3zee force-pushed the KRPC-59-stream-scoped-pkg branch from 7659308 to 6e4f3b1 Compare June 19, 2024 14:51
@Mr3zee Mr3zee changed the base branch from versioning to main June 19, 2024 14:53
@Mr3zee Mr3zee merged commit b5b76d6 into main Jun 19, 2024
4 checks passed
@Mr3zee Mr3zee deleted the KRPC-59-stream-scoped-pkg branch June 19, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees

@Mr3zee Mr3zee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mr3zee @e5l