-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KRPC-18 Add K2 and IR code generation plugins, preserve KSP for K1 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr3zee
force-pushed
the
compiler-plugin
branch
3 times, most recently
from
June 24, 2024 17:58
ad99de0
to
28bf0b9
Compare
Curious, is there more information on this change? Motivation, effect, etc |
@efemoney basically these reasons:
|
Makes sense! Thanks |
Mr3zee
changed the title
Replace KSP with Compiler Plugins
Added K2 and IR code generation plugins, preserve KSP for K1
Aug 13, 2024
Mr3zee
changed the title
Added K2 and IR code generation plugins, preserve KSP for K1
Add K2 and IR code generation plugins, preserve KSP for K1
Aug 13, 2024
* [IR] preparation for IR plugin * Introduce common IR backend plugin (2/2) (#45) * [IR] replace part of KSP with IR plugin * review comments
* Introduce K2 plugin * Update IR backend * Update to 2.0 * Fix for KT-70132
Mr3zee
force-pushed
the
compiler-plugin
branch
from
August 13, 2024 17:19
f382784
to
84a1a86
Compare
Mr3zee
force-pushed
the
compiler-plugin
branch
2 times, most recently
from
August 14, 2024 10:46
99261fc
to
c322248
Compare
Mr3zee
force-pushed
the
compiler-plugin
branch
from
August 14, 2024 11:02
c322248
to
7e5f6a2
Compare
Closed
- apiDump - Fix compilation for older Kotlin compiler plugins - Fix configs for tests and yarn.lock - Disable KSP plugin for local tests - Added 100000 requests test (checks for possible memory leaks)
Mr3zee
force-pushed
the
compiler-plugin
branch
from
August 14, 2024 11:22
7e5f6a2
to
c3cd582
Compare
e5l
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Good job! It also would be great to mention YT ticket in the header and update description
@e5l thank you! Yes, forgot to do it, well do soon |
Mr3zee
changed the title
Add K2 and IR code generation plugins, preserve KSP for K1
KRPC-18 Add K2 and IR code generation plugins, preserve KSP for K1
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for K2 code generation. Uses K2 compiler plugin instead of KSP.
Backend Compiler Plugin now generates most of the code, FIR plugin for K2 and KSP for K1 only generate minimal declarations needed for Serialization and metadata generation on the frontend.
This is a meta-PR that accumulated many other PRs, see corresponding commits and PR descriptions.