Add an adapted version of the EfficientBinaryFormat to the default tests. #2979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default EfficientBinaryFormat, and add it to the parametrizedTest. It contains some workarounds to handle json format specifics. It implements stringformat by recording the binary serialization as shadow value.
…undtrip through the EfficientBinaryFormat.
them consider shouldEncodeElementDefault's output.
pdvrieze
force-pushed
the
pdvrieze/testWithEfficientBinaryData
branch
from
870f23a to
1c82bde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set creates a simple implementation of the EfficientBinaryFormat. It is included in the existing json tests (special casing json specific serializers). This should ensure that serialization works with less forgiving formats that require in order serialization and must write defaults.