refactor #17
Merged
refactor #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asm0dey
reviewed
Jul 12, 2023
| } | ||
| sourceSets.commonTest.get().dependencies { | ||
| implementation(libs.kotlin.test) | ||
| sourceSets { |
There was a problem hiding this comment.
Here you changed the way which Sebastian recommended
There was a problem hiding this comment.
it is not good idea because it works only for common source sets. for any other user will have to use "by getting" syntax
There was a problem hiding this comment.
another point is I'd prefer to have a common approach in our templates.
we don't use sourceSets. for each source set
There was a problem hiding this comment.
With 1.9.20 there will be static accessors not just for commonMain but other default source sets (including nativeMain, iosMain and etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.