-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some bugs from testing Google Oauth #871
base: 2.x
Are you sure you want to change the base?
Conversation
Will have a look as soon as I have the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. I have
$userData = [
'name' => $socialUser->getNickname() ?: $socialUser->getName(),
];
in another app that supports login with Google and I get the original user names there. According to the documentation of the library used for this, Google should provide the user name.
Could this be a configuration issue in the Google SSO options?
Good morning!
|
Alright, I'll update the code right away, but you might keep your configuration change. |
Thank you very much! |
Thank you very much for implementing #174, I'm happy to test!
Google objected to the redirect_uri having curly braces, so I updated it to match the other providers' patterns.
Google also doesn't provide a nickname (a known limitation), so I set it to use the email as a fallback.