Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen on IPv4 and IPv6 #1260

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Listen on IPv4 and IPv6 #1260

merged 1 commit into from
Mar 2, 2024

Conversation

porjo
Copy link
Contributor

@porjo porjo commented Sep 22, 2022

Dockerfile currently only listens on IPv4. This change makes it listen on IPv6 also.

Fixes #1138

Copy link
Collaborator

@pbiering pbiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to lastest Radicale 3

@pbiering pbiering added the need:reporter feedback feedback from reporter required label Mar 1, 2024
Copy link
Contributor Author

@porjo porjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using latest v3 now

@porjo porjo requested a review from pbiering March 1, 2024 10:09
@pbiering
Copy link
Collaborator

pbiering commented Mar 1, 2024

Using latest v3 now

Thank you, while not having "Docker" here, is this still working in case IPv6 is not available on a particular setup?

@porjo
Copy link
Contributor Author

porjo commented Mar 1, 2024

Thank you, while not having "Docker" here, is this still working in case IPv6 is not available on a particular setup?

It's a good question. I tested like this:

docker run -it --rm --entrypoint /bin/ash --sysctl net.ipv6.conf.all.disable_ipv6=1 radicale
/app $ ip addr
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: tap0: <BROADCAST,UP,LOWER_UP> mtu 65520 qdisc fq_codel state UNKNOWN qlen 1000
    link/ether b2:c9:0a:15:c2:ac brd ff:ff:ff:ff:ff:ff
    inet 10.0.2.100/24 brd 10.0.2.255 scope global tap0
       valid_lft forever preferred_lft forever
/app $ bin/python bin/radicale --hosts 0.0.0.0:5232,[::]:5232 &
/app $ netstat -an
Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       
tcp        0      0 0.0.0.0:5232            0.0.0.0:*               LISTEN      
tcp        0      0 :::5232                 :::*                    LISTEN      

So the container indicates no IPv6 and Radicale starts without error when given the [::]:5232 hosts value.

@pbiering pbiering closed this Mar 2, 2024
@pbiering pbiering reopened this Mar 2, 2024
@pbiering pbiering merged commit 5678453 into Kozea:master Mar 2, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need:reporter feedback feedback from reporter required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipv6 stopped working
2 participants