Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build macOS executable for M- series Macs #2263

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JakenHerman
Copy link

@JakenHerman JakenHerman commented Oct 2, 2024

I noticed there was a GitHub Action that generated a Windows (.exe) executable, but nothing for macOS. This pull request adds a GitHub Action to generate an executable binary for macOS.

Testing

There is a test step in the GitHub Action, so no manually testing should be necessary, however, if you'd like you can download the artifact produced from the GitHub Action run. You'll need to run chmod +x weasyprint-macos/dist/weasyprint in order to be able to execute, but once you do, you can run ./weasyprint-macos/dist/weasyprint --info to verify the executable is working.

Use cases

This executable can be bundled with Electron or Tauri applications so PDF generation is a possibility without requiring users of the built applications to install additional resources.

@JakenHerman JakenHerman marked this pull request as ready for review October 2, 2024 04:55
@JakenHerman
Copy link
Author

I'm not sure where the appropriate place to update documentation on using this binary would be, but I would be happy to contribute to the documentation as the team sees fit. You can see the result of the GitHub action run on my fork here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant