Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding all files for generating paper results (in branch) #131

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

Rbravo555
Copy link
Member

No description provided.

@Rbravo555 Rbravo555 merged commit 59cccd0 into master Jan 10, 2024
1 check passed
@rubenzorrilla
Copy link
Member

I think this is quite messy and not in the line of the rest of the examples in the repo. I'd consider sticking to how the rest of application folders are organized. Besides the naming of the folders suggests that some of the examples require a specific branch to work. If this is true, such cases cannot be in this repository.

Last but important, this adds quite a lot (hundreds) of binary files. I'm not sure if this is the place for them, on top of the fact of their size, which I wonder if it could be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants