Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FSI Turek Benchmark to CoSim Examples #133

Merged
merged 12 commits into from
Feb 26, 2024
Merged

Conversation

juancamarotti
Copy link
Contributor

Adding one new FSI example to the CoSimulationApplication (FSI Turek example)

@matekelemen
Copy link
Contributor

@juancamarotti can you plz update me about what the problem with the coupling convergence was?

@juancamarotti
Copy link
Contributor Author

@matekelemen the ALE boundary conditions for the mesh motion solver were imposed incorrectly in the ProjectParametersCFD.json

@matekelemen
Copy link
Contributor

alright, can you please give me a diff on the setting that solved the issue?

@juancamarotti
Copy link
Contributor Author

@rubenzorrilla I have already changed the fluid element formulation and it is working properly! Could you review it?

"dimension" : 2,
"variable_name" : "REACTION"
},
"velocity" : {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't use velocity in this example. Can you delete it from settings?

@rubenzorrilla
Copy link
Member

@rubenzorrilla I have already changed the fluid element formulation and it is working properly! Could you review it?

Looks OK. I've nothing else to add.

@juancamarotti
Copy link
Contributor Author

@rubenzorrilla I have already changed the fluid element formulation and it is working properly! Could you review it?

Looks OK. I've nothing else to add.

Could you please approve the pull request so that I can merge it to the master branch? Thank you very much in advance

@rubenzorrilla
Copy link
Member

@rubenzorrilla I have already changed the fluid element formulation and it is working properly! Could you review it?

Looks OK. I've nothing else to add.

Could you please approve the pull request so that I can merge it to the master branch? Thank you very much in advance

There is no branch protection in the Examples repo so you can merge whenever you want.

@juancamarotti juancamarotti merged commit b1c84e1 into master Feb 26, 2024
1 check passed
@juancamarotti juancamarotti deleted the co_sim/fsi_turek branch February 26, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants