Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Runic formatting on code base #329

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

use Runic formatting on code base #329

wants to merge 4 commits into from

Conversation

KristofferC
Copy link
Owner

Want to try this out

Copy link
Collaborator

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of explicit returns: given that Julia just returns the last value of the block like any Lisp, I find it superfluous.

For functions that do not return anything, an explicit nothing can be added.

That said, if you like it this way then merging if fine with me.

@KristofferC
Copy link
Owner Author

I am not a big fan of explicit returns: given that Julia just returns the last value of the block like any Lisp, I find it superfluous.

I think the returns inside the do blocks are perhaps a bit excessive but for normal functions we used to return many "implicit" values like the return value of mv etc which was unrelated to the function. I like that this forces you to make it explicit if you actually intend to return the last value or not.

@tpapp
Copy link
Collaborator

tpapp commented Oct 18, 2024

like the return value of mv etc which was unrelated to the function

With this I agree, I just prefer nothing instead of return. But feel free to format it the way you like, this is just a personal preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants