Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related endpoints to DNSRecord status #241

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Add related endpoints to DNSRecord status #241

merged 1 commit into from
Oct 18, 2024

Conversation

maksymvavilov
Copy link
Contributor

@maksymvavilov maksymvavilov commented Sep 19, 2024

This PR uses zoneEndpoints retrieved from the provider while building plan and reports them in the spec
An is reported to a DNSRecord if an endpoint that shares rootHost with DNSrecord.
There could be 3 cases for this:

  1. Endpoint DNSName matches root host - it is reported
  2. Endpoint DNSName is a subdomain of the root host (i.e. one.example.com and example.com) - it is reported
  3. Endpoint DNS name is not sharing the host (i.e. one.example.com and two.example.com) - is not reported

The format is as proposed in #204

@maksymvavilov maksymvavilov linked an issue Sep 19, 2024 that may be closed by this pull request
@maleck13 maleck13 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 3821308 Oct 18, 2024
15 checks passed
@maksymvavilov maksymvavilov deleted the gh-205 branch November 7, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

report relevant zone records in DNS Record status
2 participants