test improvement

[maksymvavilov]

Improves two Rate Limit Policy tests:

1. The test does not evaluate one of the conditions (always passes)
2. The test does not check for the second policy. Leaves a possibility of false positive.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.43%. Comparing base (20a0530) to head (c96399a).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
+ Coverage   83.42%   83.43%   +0.01%     
==========================================
  Files          81       81              
  Lines        6943     6943              
==========================================
+ Hits         5792     5793       +1     
  Misses        926      926              
+ Partials      225      224       -1     

Flag	Coverage Δ
bare-k8s-integration	22.67% <ø> (+0.01%)	⬆️
controllers-integration	74.92% <ø> (-0.08%)	⬇️
envoygateway-integration	40.58% <ø> (+0.23%)	⬆️
gatewayapi-integration	19.68% <ø> (+0.21%)	⬆️
istio-integration	43.21% <ø> (-0.14%)	⬇️
unit	19.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api/v1beta1 (u)	90.00% <ø> (ø)
api/v1beta2 (u)	∅ <ø> (∅)
pkg/common (u)	∅ <ø> (∅)
pkg/istio (u)	62.06% <ø> (ø)
pkg/log (u)	93.18% <ø> (ø)
pkg/reconcilers (u)	24.67% <ø> (ø)
pkg/rlptools (u)	∅ <ø> (∅)
controllers (i)	86.70% <ø> (-0.05%)	⬇️

see 5 files with indirect coverage changes

[maksymvavilov]

@KevFan would you have a moment for a sanity check of this one?

[KevFan]

Looks good to me! 👍