Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Dashboard and Alerts workflow fix #837

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ehearneRedHat
Copy link
Contributor

@ehearneRedHat ehearneRedHat commented Aug 22, 2024

What:

The Verify Dashboards and Alerts workflow is broken --> https://github.com/Kuadrant/kuadrant-operator/actions/runs/10491360725

How:

This fix adds the kuadrant-system namespace to apply all configurations correctly.

Verify:

Workflow triggered and runs successfully --> https://github.com/Kuadrant/kuadrant-operator/actions/runs/10510327152/job/29118648774

Signed-off-by: ehearneredhat <[email protected]>
@ehearneRedHat ehearneRedHat changed the title Verifty Verify Dashboard and Alerts workflow fix Aug 22, 2024
@ehearneRedHat ehearneRedHat self-assigned this Aug 22, 2024
@ehearneRedHat
Copy link
Contributor Author

@R-Lawton I found the bug! Feel free to review when you have the chance :)

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (ece13e8) to head (b90235e).
Report is 174 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   80.20%   82.08%   +1.87%     
==========================================
  Files          64       76      +12     
  Lines        4492     6090    +1598     
==========================================
+ Hits         3603     4999    +1396     
- Misses        600      746     +146     
- Partials      289      345      +56     
Flag Coverage Δ
bare-k8s-integration 4.50% <ø> (?)
controllers-integration 71.92% <ø> (?)
gatewayapi-integration 10.96% <ø> (?)
integration ?
istio-integration 56.35% <ø> (?)
unit 31.58% <ø> (+1.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 85.35% <80.00%> (-6.08%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 72.50% <ø> (-1.41%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 83.64% <ø> (+4.19%) ⬆️
controllers (i) 82.49% <81.81%> (+5.69%) ⬆️

see 42 files with indirect coverage changes

@ehearneRedHat
Copy link
Contributor Author

@R-Lawton I entrust to you my PR, please be kind to it !

Thank you for being my mentor over the past eight months, helping me with any problems faced and helping me grow during my time here.

Until next time, Kuadrant !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready For Review
Development

Successfully merging this pull request may close these issues.

1 participant