-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify Dashboard and Alerts workflow fix #837
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ehearneredhat <[email protected]>
Signed-off-by: ehearneredhat <[email protected]>
Signed-off-by: ehearneredhat <[email protected]>
Signed-off-by: ehearneredhat <[email protected]>
@R-Lawton I found the bug! Feel free to review when you have the chance :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 80.20% 82.08% +1.87%
==========================================
Files 64 76 +12
Lines 4492 6090 +1598
==========================================
+ Hits 3603 4999 +1396
- Misses 600 746 +146
- Partials 289 345 +56
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@R-Lawton I entrust to you my PR, please be kind to it ! Thank you for being my mentor over the past eight months, helping me with any problems faced and helping me grow during my time here. Until next time, Kuadrant ! |
What:
The
Verify Dashboards and Alerts
workflow is broken --> https://github.com/Kuadrant/kuadrant-operator/actions/runs/10491360725How:
This fix adds the
kuadrant-system
namespace to apply all configurations correctly.Verify:
Workflow triggered and runs successfully --> https://github.com/Kuadrant/kuadrant-operator/actions/runs/10510327152/job/29118648774