-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dns record orphan alert #862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
maleck13
force-pushed
the
sample-orphan-alert-gh-202
branch
4 times, most recently
from
September 20, 2024 10:39
a7621e6
to
da2022a
Compare
maleck13
commented
Sep 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
==========================================
- Coverage 80.20% 78.61% -1.60%
==========================================
Files 64 91 +27
Lines 4492 7046 +2554
==========================================
+ Hits 3603 5539 +1936
- Misses 600 1092 +492
- Partials 289 415 +126
Flags with carried forward coverage won't be shown. Click here to find out more.
|
maleck13
force-pushed
the
sample-orphan-alert-gh-202
branch
2 times, most recently
from
September 20, 2024 11:33
e775412
to
c9fd9a1
Compare
Signed-off-by: craig <[email protected]> add orphan record mitigation doc fix lint improve alert query
maleck13
force-pushed
the
sample-orphan-alert-gh-202
branch
from
September 20, 2024 13:33
c9fd9a1
to
54222b4
Compare
I'm seeing a vendoring issue locally when running
|
mikenairn
reviewed
Sep 23, 2024
mikenairn
reviewed
Sep 23, 2024
mikenairn
reviewed
Sep 23, 2024
mikenairn
reviewed
Sep 23, 2024
Co-authored-by: Michael Nairn <[email protected]>
Co-authored-by: Michael Nairn <[email protected]>
Co-authored-by: Michael Nairn <[email protected]>
mikenairn
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification:
and it should become active
Follow the doc at https://github.com/Kuadrant/kuadrant-operator/blob/sample-orphan-alert-gh-202/doc/user-guides/orphan-dns-records.md