Update openshift observability resources to use gateway-system namespace #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Martin <[email protected]>
david-martin
commented
Oct 31, 2024
| @@ -183,7 +183,7 @@ To scrape these additional metrics, you can install a `kube-state-metrics` insta | |||
|
|
|||
| ```bash | |||
| kubectl apply -f https://raw.githubusercontent.com/Kuadrant/kuadrant-operator/main/config/observability/openshift/kube-state-metrics.yaml | |||
| kubectl apply -k https://github.com/Kuadrant/gateway-api-state-metrics?ref=main | |||
| kubectl apply -k https://github.com/Kuadrant/gateway-api-state-metrics/config/kuadrant?ref=0.5.0 | |||
There was a problem hiding this comment.
@eguzki I forgot to land this change as well here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
===========================================
- Coverage 81.49% 68.93% -12.57%
===========================================
Files 102 110 +8
Lines 7177 9572 +2395
===========================================
+ Hits 5849 6598 +749
- Misses 898 2548 +1650
+ Partials 430 426 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eguzki
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for some issues hit during install with @eguzki