Skip to content

Commit

Permalink
Update workflows to support merge queue
Browse files Browse the repository at this point in the history
Signed-off-by: Adam Cattermole <[email protected]>
  • Loading branch information
adam-cattermole committed Jan 31, 2025
1 parent 066b218 commit af33ba5
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 8 deletions.
21 changes: 17 additions & 4 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
name: e2e tests
on:
push:
branches:
- 'main'
branches: ['main']
pull_request:
branches:
- '*'
branches: ['*']
merge_group:
types: [checks_requested]
workflow_dispatch:

jobs:
limits_file_watcher:
name: Limits File Watcher in k8s environment
Expand Down Expand Up @@ -134,3 +136,14 @@ jobs:
command: |
curl -s "http://127.0.0.1:18080/limits/other_namespace" | tee other-limits.json
NUM_LIMITS=$(jq --exit-status 'length' other-limits.json) && test ${NUM_LIMITS} -eq 1
required-checks:
name: E2E Tests Required Checks
# This check adds a list of checks to one job to simplify adding settings to the repo.
# If a new check is added in this file, and it should be retested on entry to the merge queue,
# it needs to be added to the list below aka needs: [ existing check 1, existing check 2, new check ].
needs: [ limits_file_watcher, limits_file_watcher_on_docker ]
if: always()
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: echo '${{ toJSON(needs) }}' | jq -e 'all(.[]; .result == "success" or .result == "skipped")'
20 changes: 16 additions & 4 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ name: Limitador

on:
push:
branches:
- 'main'
branches: ['main']
pull_request:
branches:
- '*'
branches: ['*']
merge_group:
types: [checks_requested]
workflow_dispatch:
schedule:
- cron: '5 4 * * *'

Expand Down Expand Up @@ -78,3 +79,14 @@ jobs:
ips=$(kubectl get nodes -lkubernetes.io/hostname!=kind-control-plane -ojsonpath='{.items[*].status.addresses[?(@.type=="InternalIP")].address}')
port=$(kubectl -n default get service kuard -ojsonpath='{.spec.ports[?(@.name=="envoy-http")].nodePort}')
curl "http://${ips[0]}:${port}"
required-checks:
name: Limitador Required Checks
# This check adds a list of checks to one job to simplify adding settings to the repo.
# If a new check is added in this file, and it should be retested on entry to the merge queue,
# it needs to be added to the list below aka needs: [ existing check 1, existing check 2, new check ].
needs: [ check, test, fmt, clippy, kind ]
if: always()
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: echo '${{ toJSON(needs) }}' | jq -e 'all(.[]; .result == "success" or .result == "skipped")'

0 comments on commit af33ba5

Please sign in to comment.